dj7nt/award
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Activity

revert: remove LoTW sync type support (QSL/QSO delta/full)

Browse Source 
This reverts commit 5b78935 which added:
- Sync type parameter (qsl_delta, qsl_full, qso_delta, qso_full)
- getLastLoTWQSODate() function
- Sync type dropdown on QSO page
- Job queue handling of sync types

Reason: LoTW doesn't provide DXCC entity data for unconfirmed QSOs,
which causes award calculation issues. Going back to QSL-only sync.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Joerg
2026-01-20 12:28:23 +01:00
parent 688b0fc255
commit 310b1547c4
5 changed files with 24 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
src/backend/services/lotw.service.js
View File

@@ -49,24 +49,15 @@ const sleep = (ms) => new Promise(resolve => setTimeout(resolve, ms));
/**
* Fetch QSOs from LoTW with retry support
* @param {string} lotwUsername - LoTW username
* @param {string} lotwPassword - LoTW password
* @param {Date|null} sinceDate - Optional date for incremental sync
* @param {string} syncType - Type of sync: 'qsl_delta' (default), 'qsl_full', 'qso_delta', 'qso_full'
*/
async function fetchQSOsFromLoTW(lotwUsername, lotwPassword, sinceDate = null, syncType = 'qsl_delta') {
async function fetchQSOsFromLoTW(lotwUsername, lotwPassword, sinceDate = null) {
const url = 'https://lotw.arrl.org/lotwuser/lotwreport.adi';
// Determine qso_qsl parameter based on sync type
// qsl_* = only QSLs (confirmed QSOs)
// qso_* = all QSOs (confirmed + unconfirmed)
const qsoQslValue = syncType.startsWith('qsl') ? 'yes' : 'no';
const params = new URLSearchParams({
login: lotwUsername,
password: lotwPassword,
qso_query: '1',
qso_qsl: qsoQslValue,
qso_qsl: 'yes',
qso_qsldetail: 'yes',
qso_mydetail: 'yes',
qso_withown: 'yes',
@@ -75,9 +66,9 @@ async function fetchQSOsFromLoTW(lotwUsername, lotwPassword, sinceDate = null, s
if (sinceDate) {
const dateStr = sinceDate.toISOString().split('T')[0];
params.append('qso_qslsince', dateStr);
logger.debug('Incremental sync', { syncType, since: dateStr });
logger.debug('Incremental sync since', { date: dateStr });
} else {
logger.debug('Full sync', { syncType });
logger.debug('Full sync - fetching all QSOs');
}
const fullUrl = `${url}?${params.toString()}`;
@@ -196,9 +187,8 @@ function convertQSODatabaseFormat(adifQSO, userId) {
* @param {string} lotwPassword - LoTW password
* @param {Date|null} sinceDate - Optional date for incremental sync
* @param {number|null} jobId - Optional job ID for progress tracking
* @param {string} syncType - Type of sync: 'qsl_delta' (default), 'qsl_full', 'qso_delta', 'qso_full'
*/
export async function syncQSOs(userId, lotwUsername, lotwPassword, sinceDate = null, jobId = null, syncType = 'qsl_delta') {
export async function syncQSOs(userId, lotwUsername, lotwPassword, sinceDate = null, jobId = null) {
if (jobId) {
await updateJobProgress(jobId, {
message: 'Fetching QSOs from LoTW...',
@@ -206,7 +196,7 @@ export async function syncQSOs(userId, lotwUsername, lotwPassword, sinceDate = n
});
}
const adifQSOs = await fetchQSOsFromLoTW(lotwUsername, lotwPassword, sinceDate, syncType);
const adifQSOs = await fetchQSOsFromLoTW(lotwUsername, lotwPassword, sinceDate);
// Check for error response from LoTW fetch
if (!adifQSOs) {
@@ -514,27 +504,6 @@ export async function getLastLoTWQSLDate(userId) {
return new Date(`${year}-${month}-${day}`);
}
/**
* Get the date of the last LoTW QSO for a user (for incremental sync of all QSOs)
*/
export async function getLastLoTWQSODate(userId) {
const [result] = await db
.select({ maxDate: max(qsos.qsoDate) })
.from(qsos)
.where(eq(qsos.userId, userId));
if (!result || !result.maxDate) return null;
const dateStr = result.maxDate;
if (!dateStr || dateStr === '') return null;
const year = dateStr.substring(0, 4);
const month = dateStr.substring(4, 6);
const day = dateStr.substring(6, 8);
return new Date(`${year}-${month}-${day}`);
}
/**
* Delete all QSOs for a user
*/